Skip to content

Conversation

@Ashnar2602
Copy link
Contributor

@Ashnar2602 Ashnar2602 commented Jan 17, 2026

Summary by cubic

Adds full Romanian localization and enables the "ro" locale in the build. Fixes a missing Italian string used in the install space dialog.

Written for commit e98cccf. Summary will update on new commits.

Summary by CodeRabbit

Release Notes

  • New Features
    • Added Romanian language support to the app, expanding multilingual capabilities
    • Updated Italian translations with new content for Steam installation information

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 17, 2026

📝 Walkthrough

Walkthrough

Added Romanian localization support by including "ro" in resourceConfigurations and creating a comprehensive values-ro/strings.xml file with 973 lines of Romanian translations. Also added a steam_install_space string resource to the Italian translations file.

Changes

Cohort / File(s) Summary
Build Configuration
app/build.gradle.kts
Added "ro" (Română) to resourceConfigurations in android.defaultConfig to enable Romanian locale support.
Localization Resources
app/src/main/res/values-it/strings.xml, app/src/main/res/values-ro/strings.xml
Added steam_install_space string resource to Italian translations. Created new Romanian locale resource file with extensive translations covering app metadata, authentication, settings (general, emulation, graphics, input, rendering), library/game management, 2FA, Wine/Proton management, UI labels, and domain-specific terms across all app sections.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Poem

🐰✨ A Romanian tongue joins the chorus,
Nine-hundred seventy-three words to explore us!
From "ro" in the config, a new path unfolds,
Where strings dance and dialogs' tales are told!
Winlator whispers in lingua română 🎮🌍

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title contains a typo ('Romenian' instead of 'Romanian') and uses 'mssing' instead of 'missing', but accurately describes the main changes: adding Romanian translation and fixing a missing string in Italian translation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@app/src/main/res/values-ro/strings.xml`:
- Line 149: Fix the typo in the Romanian string resource named
"processor_affinity": change the value from "Afiinitate procesor" to the correct
"Afinitate procesor" in the strings.xml entry for processor_affinity so the
displayed text uses the proper Romanian spelling.
🧹 Nitpick comments (1)
app/src/main/res/values-ro/strings.xml (1)

427-432: Consider: Inconsistent indentation style

Lines 427 onwards use tab indentation while the earlier part of the file uses spaces. This doesn't affect functionality but standardizing to one style (spaces, matching the first half of the file) would improve consistency.

<string name="about">Despre</string>
<string name="open_file">Deschide fișier</string>
<string name="download_file">Descarcă fișier</string>
<string name="processor_affinity">Afiinitate procesor</string>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Typo: "Afiinitate" should be "Afinitate"

There's an extra 'i' in the Romanian word for "processor affinity". The correct spelling is "Afinitate procesor".

🔤 Proposed fix
-    <string name="processor_affinity">Afiinitate procesor</string>
+    <string name="processor_affinity">Afinitate procesor</string>
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<string name="processor_affinity">Afiinitate procesor</string>
<string name="processor_affinity">Afinitate procesor</string>
🤖 Prompt for AI Agents
In `@app/src/main/res/values-ro/strings.xml` at line 149, Fix the typo in the
Romanian string resource named "processor_affinity": change the value from
"Afiinitate procesor" to the correct "Afinitate procesor" in the strings.xml
entry for processor_affinity so the displayed text uses the proper Romanian
spelling.

@utkarshdalal utkarshdalal merged commit a5ed4dd into utkarshdalal:master Jan 19, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants