-
Notifications
You must be signed in to change notification settings - Fork 82
Added Romenian translation by MXXME, fixed one mssing string in Italian translation by me. #422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughAdded Romanian localization support by including "ro" in resourceConfigurations and creating a comprehensive values-ro/strings.xml file with 973 lines of Romanian translations. Also added a steam_install_space string resource to the Italian translations file. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 3 files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@app/src/main/res/values-ro/strings.xml`:
- Line 149: Fix the typo in the Romanian string resource named
"processor_affinity": change the value from "Afiinitate procesor" to the correct
"Afinitate procesor" in the strings.xml entry for processor_affinity so the
displayed text uses the proper Romanian spelling.
🧹 Nitpick comments (1)
app/src/main/res/values-ro/strings.xml (1)
427-432: Consider: Inconsistent indentation styleLines 427 onwards use tab indentation while the earlier part of the file uses spaces. This doesn't affect functionality but standardizing to one style (spaces, matching the first half of the file) would improve consistency.
| <string name="about">Despre</string> | ||
| <string name="open_file">Deschide fișier</string> | ||
| <string name="download_file">Descarcă fișier</string> | ||
| <string name="processor_affinity">Afiinitate procesor</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: "Afiinitate" should be "Afinitate"
There's an extra 'i' in the Romanian word for "processor affinity". The correct spelling is "Afinitate procesor".
🔤 Proposed fix
- <string name="processor_affinity">Afiinitate procesor</string>
+ <string name="processor_affinity">Afinitate procesor</string>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <string name="processor_affinity">Afiinitate procesor</string> | |
| <string name="processor_affinity">Afinitate procesor</string> |
🤖 Prompt for AI Agents
In `@app/src/main/res/values-ro/strings.xml` at line 149, Fix the typo in the
Romanian string resource named "processor_affinity": change the value from
"Afiinitate procesor" to the correct "Afinitate procesor" in the strings.xml
entry for processor_affinity so the displayed text uses the proper Romanian
spelling.
Summary by cubic
Adds full Romanian localization and enables the "ro" locale in the build. Fixes a missing Italian string used in the install space dialog.
Written for commit e98cccf. Summary will update on new commits.
Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.