-
Notifications
You must be signed in to change notification settings - Fork 84
Language selector english translations #427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Language selector english translations #427
Conversation
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. 📝 WalkthroughWalkthroughThis change updates the display strings in the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~4 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 1 file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@app/src/main/java/app/gamenative/utils/LocaleHelper.kt`:
- Line 24: The line containing the map entry `"uk" to "Українська (Ukrainian)"`
in LocaleHelper.kt uses a TAB for indentation; replace that TAB with the same
number of spaces used elsewhere in the file to match existing indentation style
(e.g., convert the leading TAB to spaces so the mapping aligns with other
entries in the locale map).
| "zh-CN" to "简体中文", | ||
| "fr" to "Français", | ||
| "de" to "Deutsch" | ||
| "uk" to "Українська (Ukrainian)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent indentation: TAB used instead of spaces.
Line 24 uses a TAB character for indentation while the rest of the file uses spaces. This should be fixed for consistency.
🔧 Suggested fix
- "uk" to "Українська (Ukrainian)",
+ "uk" to "Українська (Ukrainian)",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "uk" to "Українська (Ukrainian)", | |
| "uk" to "Українська (Ukrainian)", |
🤖 Prompt for AI Agents
In `@app/src/main/java/app/gamenative/utils/LocaleHelper.kt` at line 24, The line
containing the map entry `"uk" to "Українська (Ukrainian)"` in LocaleHelper.kt
uses a TAB for indentation; replace that TAB with the same number of spaces used
elsewhere in the file to match existing indentation style (e.g., convert the
leading TAB to spaces so the mapping aligns with other entries in the locale
map).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="app/src/main/java/app/gamenative/utils/LocaleHelper.kt">
<violation number="1" location="app/src/main/java/app/gamenative/utils/LocaleHelper.kt:29">
P3: "Romenian" is misspelled; the correct English name is "Romanian".</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@app/src/main/java/app/gamenative/utils/LocaleHelper.kt`:
- Around line 28-29: The map literal in LocaleHelper (the LANGUAGE_DISPLAY_NAMES
/ language map in LocaleHelper.kt) has a missing comma between the entries `"de"
to "Deutsch (German)"` and `"ro" to "Română (Romenian)"`; add a comma after the
`"Deutsch (German)"` entry so the map entries are properly separated and the
file compiles.
- Line 29: The locale map in LocaleHelper.kt has a syntax error and a
misspelling: add the missing comma after the "de" entry (the line with "de" to
"Deutsch (German)") and correct the Romanian label from "Romenian" to "Romanian"
(the line with "ro" to "Română (Romanian)"); update the entries in the locale
map where these keys/values are defined to ensure the map compiles and the label
is spelled correctly.
f320012 to
4dc1f78
Compare
Add english translations to language selector
Summary by cubic
Add English translations to language selector labels to make choices clear for all users. Also add Romanian and clarify variants like Traditional and Simplified Chinese.
Written for commit 4dc1f78. Summary will update on new commits.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.