Skip to content

fix: add matching favicon for sidebar branding consistency (#2363) - #2432

Open
aaniya22 wants to merge 2 commits into
utksh1:mainfrom
aaniya22:fix/favicon-branding-mismatch-2363
Open

fix: add matching favicon for sidebar branding consistency (#2363)#2432
aaniya22 wants to merge 2 commits into
utksh1:mainfrom
aaniya22:fix/favicon-branding-mismatch-2363

Conversation

@aaniya22

@aaniya22 aaniya22 commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Description

Adds a favicon matching the sidebar's SecuScan shield branding. Previously index.html had no favicon link at all, so the browser tab displayed a generic default icon while the sidebar rendered a red glowing shield via a Material Symbols font icon. Added an SVG favicon (red shield, same color and glow as the sidebar) and linked it in the document head.

Related Issues

Fixes #2363

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Ran npm run dev in frontend/, opened 127.0.0.1:5173, hard-refreshed (favicons are cached by the browser), and confirmed the tab icon now shows the red shield, matching the sidebar logo. Tested in Chrome.

Checklist

  • My code follows the code style of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.

@utksh1 utksh1 added area:frontend Frontend React/UI work level:beginner 20 pts difficulty label for small beginner-friendly PRs type:design Design or UX work category bonus label labels Aug 4, 2026
@utksh1
utksh1 force-pushed the fix/favicon-branding-mismatch-2363 branch from 92ab224 to a732ee3 Compare August 4, 2026 10:45

@utksh1 utksh1 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the favicon addition and the existing required checks are green. Approved for squash merge.

@utksh1

utksh1 commented Aug 4, 2026

Copy link
Copy Markdown
Owner

The favicon change is approved from a code-review perspective. The current branch is blocked by the repository-required frontend audit, which reports a pre-existing high-severity undici vulnerability; I am leaving the security gate intact rather than using an admin merge.

@utksh1
utksh1 force-pushed the fix/favicon-branding-mismatch-2363 branch from a732ee3 to 595a0a6 Compare August 5, 2026 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:frontend Frontend React/UI work level:beginner 20 pts difficulty label for small beginner-friendly PRs type:design Design or UX work category bonus label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] : Application Favicon Does Not Match Sidebar Logo Branding

2 participants