fix: add matching favicon for sidebar branding consistency (#2363) - #2432
Open
aaniya22 wants to merge 2 commits into
Open
fix: add matching favicon for sidebar branding consistency (#2363)#2432aaniya22 wants to merge 2 commits into
aaniya22 wants to merge 2 commits into
Conversation
utksh1
force-pushed
the
fix/favicon-branding-mismatch-2363
branch
from
August 4, 2026 10:45
92ab224 to
a732ee3
Compare
utksh1
approved these changes
Aug 4, 2026
utksh1
left a comment
Owner
There was a problem hiding this comment.
Reviewed the favicon addition and the existing required checks are green. Approved for squash merge.
Owner
|
The favicon change is approved from a code-review perspective. The current branch is blocked by the repository-required frontend audit, which reports a pre-existing high-severity undici vulnerability; I am leaving the security gate intact rather than using an admin merge. |
utksh1
force-pushed
the
fix/favicon-branding-mismatch-2363
branch
from
August 5, 2026 07:50
a732ee3 to
595a0a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a favicon matching the sidebar's SecuScan shield branding. Previously
index.htmlhad no favicon link at all, so the browser tab displayed a generic default icon while the sidebar rendered a red glowing shield via a Material Symbols font icon. Added an SVG favicon (red shield, same color and glow as the sidebar) and linked it in the document head.Related Issues
Fixes #2363
Type of Change
How Has This Been Tested?
Ran
npm run devinfrontend/, opened127.0.0.1:5173, hard-refreshed (favicons are cached by the browser), and confirmed the tab icon now shows the red shield, matching the sidebar logo. Tested in Chrome.Checklist