test: add unit tests for _validate_lengths field length guard - #2437
Merged
Conversation
Covers valid/boundary/over-limit cases for name, description, and notes fields, plus custom resource_type substitution and None handling for optional fields. Closes utksh1#2307.
utksh1
force-pushed
the
test/validate-lengths-2307
branch
from
August 4, 2026 10:03
0f57159 to
9036a2b
Compare
utksh1
approved these changes
Aug 4, 2026
utksh1
left a comment
Owner
There was a problem hiding this comment.
The code change is reviewed and the backend/lint checks are green. Merge remains blocked by the required frontend audit, which reports the pre-existing high-severity undici vulnerability; I am not bypassing that security gate.
utksh1
approved these changes
Aug 5, 2026
utksh1
left a comment
Owner
There was a problem hiding this comment.
Reviewed the current head, including the undici lockfile security update. The focused validation tests pass, all required checks are green, and the branch is clean for squash merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds unit tests for the
_validate_lengthshelper inbackend/secuscan/routes.py, which enforces maximum field lengths (255 chars forname, 2000 chars fordescription/notes) before data reaches the database. Covers valid/boundary/over-limit cases for name, description, and notes fields, plus customresource_typesubstitution andNonehandling for optional fields.Related Issues
Closes #2307
Type of Change
How Has This Been Tested?
Ran
python -m pytest testing/backend/unit/test_routes_validate_lengths.py -vlocally — all 9 tests pass. Coverage includes:HTTPExceptionwith status 400 and the correct detail messageresource_typecorrectly substituted into the error messageNonevalues for all optional fields — confirmed to pass without raisingChecklist