test: add tests for NetworkPolicyEngine audit export and clear (closes #2447) - #2452
Open
tmdeveloper007 wants to merge 2 commits into
Open
test: add tests for NetworkPolicyEngine audit export and clear (closes #2447)#2452tmdeveloper007 wants to merge 2 commits into
tmdeveloper007 wants to merge 2 commits into
Conversation
utksh1
requested changes
Aug 4, 2026
utksh1
left a comment
Owner
There was a problem hiding this comment.
Request changes: this test module also mutates the module-level singleton without restoring it and hard-codes a temporary filesystem path for its audit file. Use the pytest temporary-path fixture plus a fixture that restores singleton state after each test. Parse CSV with Python csv instead of splitting on newlines, and remove the unused pytest import.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds unit tests for
NetworkPolicyEngine.export_audit_logandNetworkPolicyEngine.clear_audit_entriesinbackend.secuscan.network_policy.Changes
testing/backend/unit/test_network_policy_audit_export.pyclear entries, post-clear independence
Testing
python -m pytest testing/backend/unit/test_network_policy_audit_export.py --noconftest -v