fix(lib): restore automatic hashtag creation for unknown tags

[antontranelis]

Summary

• Fix stale closure bug in useTags.tsx that prevented addTag from accessing current state
• Add missing useEffect in PopupView.tsx to persist newly detected hashtags to the database

Problem

Hashtags in item text that didn't exist in the database were not being automatically created. For example, #networking would appear as plain black text instead of being recognized as a hashtag with a color.

Root Causes

1. Stale Closure in addTag (useTags.tsx)

The addTag function used tags and api from the closure scope, which were stale when the function was called:

// Before: stale closure
const addTag = (tag: Tag) => {
  dispatch({ type: 'ADD', tag })
  if (!tags.some(...)) {  // ← tags is stale
    api.createItem && api.createItem(tag)  // ← api is stale
  }
}

2. Missing Persistence (PopupView.tsx)

New tags were detected and collected in newTagsToAdd state, but never actually persisted:

// Tags were added to local state...
setNewTagsToAdd((current) => [...current, newTag])
// ...but never sent to the database

Solution

useTags.tsx

• Use useRef for apiRef and tagsRef to always access current values
• Wrap addTag in useCallback with empty dependencies

PopupView.tsx

• Import useAddTag hook
• Add useEffect that calls addTag for each new tag when newTagsToAdd changes

Test plan

• Create an item with a new hashtag (e.g., #testnewtag)
• Verify the hashtag appears with a random color (not black)
• Refresh the page and verify the hashtag persists with its color
• Check the database to confirm the tag was created

🤖 Generated with Claude Code

[mahula]

augment review

[augmentcode]

🤖 Augment PR Summary

Summary: Restores automatic creation/persistence of unknown hashtags by fixing stale state access in the tag manager and reintroducing a missing persistence step when items/tags finish loading.

Changes:

• Refactors `useTags` to avoid stale closures by storing the current API and tag list in `useRef`.
• Makes `addTag` stable via `useCallback` while still persisting newly-added tags through `ItemsApi.createItem`.
• Adds `processItemsTags(items)` to scan item text for hashtags and auto-create missing tags with generated colors.
• Updates `PopupView` to run `processItemsTags` once tags and items are fully loaded.
• Removes the previous per-item “newTagsToAdd” tracking logic from `PopupView` in favor of centralized processing.
• Adds a comprehensive `useTags.spec.tsx` suite covering state, API integration, hashtag extraction/deduping, and color assignment.

Technical Notes: Auto-created tags use crypto.randomUUID() for IDs and randomColor() for consistent UI coloring; persistence relies on an injected ItemsApi<Tag> implementation.

_{🤖 Was this summary useful? React with 👍 or 👎}

[augmentcode]

Review completed. 3 suggestions posted.

Comment augment review to trigger a new review at any time.