feat(other): add unit and e2e tests for info modal route (#657)#703
Merged
mahula merged 1 commit intofeature/info-modal-routefrom Feb 6, 2026
Merged
feat(other): add unit and e2e tests for info modal route (#657)#703mahula merged 1 commit intofeature/info-modal-routefrom
mahula merged 1 commit intofeature/info-modal-routefrom
Conversation
Collaborator
Author
|
augment review |
🤖 Augment PR SummarySummary: Improves coverage and stability around the route-based Info modal introduced earlier. Changes:
Technical Notes: E2E assertions rely on the overlay’s Tailwind utility classes ( 🤖 Was this summary useful? React with 👍 or 👎 |
- Remove setTimeout firing after unmount in ModalContent (CR1) - 4 Vitest unit tests for InfoRedirect guard logic - 3 Cypress E2E tests for route, navigation, and close flow - Restore window.location in afterEach to prevent cross-suite leaks
a13d1b5 to
9c2b111
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test coverage and CR1 fix for PR #657
Bug fix (CR1 from review)
setTimeoutfiring after unmount inModalContent.tsxsetChapterUnit Tests (Vitest) —
InfoRedirect.spec.tsx(5 tests)/infowhen enabled and pathname is/enabled=false/E2E Tests (Cypress) —
info-modal.cy.ts(4 tests)/inforenders the modal?icon navigates to/info//Design decisions
Modal.tsx: Zero-logic wrapper, tested implicitly via E2EPull Request opened by Augment Code with guidance from the PR author