Option to Send deliverSmResp manually#27
Open
fjordansilva wants to merge 6 commits into
Open
Conversation
…ssary for async systems
Check if the message deliver_sm_resp can be sent (is Transmittable) before sending.
|
Looks like you made too many trivial changes that it has become hard to find your changes that matter. Try to avoid automatic formatting or changes done by IDE. |
|
I've copied your pull request into the branch here: https://github.com/opentelecoms-org/jsmpp/commits/fjordansilva-master to see it build in travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifying the interface MessageReceiverListener, adding a boolean return value to onAcceptDeliverSm the user can choose if JSMPP sends the deliver_sm_resp message once the method has finished or (using FALSE value) doesn't allow to JSMPP to send the message.
This modification is necessary for working with async systems (Vert.x for example). With async system you can not send a response to SMSC because most of the times the original message ( deliver_sm ) has not been processed.
This PR also fix a NullPointer exception that happens when JSMPP tryes to bind to a SMSC that doesn't replay any optional parameter