Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update download_global_DEM parsing #4

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Update download_global_DEM parsing #4

merged 1 commit into from
Nov 7, 2024

Conversation

dshean
Copy link
Member

@dshean dshean commented Aug 9, 2024

Not tested extensively, but made group parser, and added option to take a raster_fn to define extent.

Change options -poly_fn to -vector_fn, which might break downstream calls. Can revert back if desired. I believe there is better support in latest GDAL/OGR to determine if a file is raster or vector, but I didn't have time to look at this. Had to add rasterio dependency to read raster_fn

Added simple padding in decimal degrees for now.

We eventually support a CRS argument for the extent/pad values, if they are not EPSG:4326

@dshean
Copy link
Member Author

dshean commented Sep 20, 2024

Hi @ShashankBice, some updates to the parser here, maybe consider merging before investigating #5

@ShashankBice ShashankBice merged commit f6c24eb into main Nov 7, 2024
@ShashankBice
Copy link
Member

Thank you for the pull request David, I will be testing the updates now, but looks like it should work well!

Cheers,
Shashank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants