Update download_global_DEM parsing #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ShashankBice, some updates to the parser here, maybe consider merging before investigating #5 |
|
Thank you for the pull request David, I will be testing the updates now, but looks like it should work well! Cheers, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not tested extensively, but made group parser, and added option to take a raster_fn to define extent.
Change options -poly_fn to -vector_fn, which might break downstream calls. Can revert back if desired. I believe there is better support in latest GDAL/OGR to determine if a file is raster or vector, but I didn't have time to look at this. Had to add rasterio dependency to read raster_fn
Added simple padding in decimal degrees for now.
We eventually support a CRS argument for the extent/pad values, if they are not EPSG:4326