Reconnecting synchronous sink #52
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly reconnects on failures using the provided backoff strategy.
Contributor
|
Why implement reconnection at the synchronous level? A reconnecting async sink would be more flexible and useful in a wider set of contexts. |
Contributor
|
How might this interact with |
Contributor
Author
|
The reason why I've implemented it at the synchronous level is that I can just return error to any pending write calls, when the sink is disconnected, as I don't know whether the message was sent successfully. This is not possible in the asynchronous case as then I can only send an acknowledgement. We could do something similar for async sink, but in that case we could only reconnect when there are no pending messages. We could make this a parameter in the suburl, so that the resulting sink is wrapped in the reconnecting one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add experimental version of synchronous sink adapter that automatically reconnects on failures using the provided backoff strategy. It also periodically checks the status of the underlying async sink and reconnects as necessary. I've just quickly put this together, so it's not fully tested yet, but I think it should work. It's a breaking change so I've put it to experimental folder for now.