Ensure straw store is closed when initialising freezer via url. #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanbrandhorst
approved these changes
Feb 17, 2020
mjgarton
reviewed
Mar 30, 2020
| func closeAll(closers []io.Closer) (outErr error) { | ||
| for _, c := range closers { | ||
| if err := c.Close(); err != nil { | ||
| outErr = multierror.Append(outErr, err) |
Contributor
There was a problem hiding this comment.
closeAll would be about 1 line longer if it didn't use multierror. Personally, I don't think it's worth the extra dependency.
Also, the call sites would be cleaner if this was variadic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.