Skip to content

Activity Scheduling: Schedule time cannot be in the past #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

anantmittal
Copy link
Collaborator

@anantmittal anantmittal commented Mar 28, 2023

Issue:

Right now people can’t schedule an activity on a date that’s already passed. However, they can schedule an activity that happened earlier in the day. For example, at noon, I can schedule an activity at 11am. We should validate the scheduled time to be past the current time during scheduling.

@anantmittal anantmittal requested a review from jayfo March 28, 2023 21:27
@jayfo
Copy link
Contributor

jayfo commented Jun 26, 2023

Discussed w/ Anant on 6/26. I'm unsure about this.

If I decide to do an activity today, then want to capture that in the app afterwards, I think I should be allowed to do that.

The current implementation also does not handle a case of repeating activities that include today but occur at an earlier time.

And of course both of the above could be true at the same time. I do an activity, decide I want to schedule it on a repeating basis, but then cannot because the time has already passed for today.

Overall I think this constraint might be too strict without clear benefit.

@jayfo
Copy link
Contributor

jayfo commented Jun 26, 2023

To discuss w/ @garyhsieh. After that, decide whether to close (i.e., if this traced back to Gary) or to discuss with larger team (i.e., if this traced back to somebody there).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants