-
Notifications
You must be signed in to change notification settings - Fork 13
feat: Shelter Sync #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Needs compression - Needs user testing and deployment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all looks ok to me apart from the obvious wip endpoint but i'll give this an actual test out in a sec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ive said most of this already but for formalism:
- this should automatically sync before plugins load on startup, and push after any changes (or, if that's infeasible, periodically)
- bailing out silently on conflicts isn't gonna fly, we need some way to automatically figure out what can be automatically skipped, and to show a ui for what can't be easily merged
- maybe store timestamps with each individual plugin at the time that it was last modified via shelter storage and then use that to resolve conflicts per-plugin?
- export modals not closing after success isn't great
also on a fresh instance you can't pull due to |
…ive event fixes the issue noticed here [1] and here [2] [1] #42 (comment) [2] https://discord.com/channels/824921608560181258/824921608560181261/1360141796188880968
No description provided.