Skip to content

feat: Shelter Sync #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Conversation

taskylizard
Copy link
Member

No description provided.

taskylizard referenced this pull request in taskylizard/shelter-plugins Feb 19, 2025
@taskylizard taskylizard marked this pull request as ready for review March 1, 2025 20:28
@taskylizard taskylizard marked this pull request as draft March 2, 2025 07:30
Copy link
Member

@yellowsink yellowsink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all looks ok to me apart from the obvious wip endpoint but i'll give this an actual test out in a sec

Copy link
Member

@yellowsink yellowsink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ive said most of this already but for formalism:

  • this should automatically sync before plugins load on startup, and push after any changes (or, if that's infeasible, periodically)
  • bailing out silently on conflicts isn't gonna fly, we need some way to automatically figure out what can be automatically skipped, and to show a ui for what can't be easily merged
    • maybe store timestamps with each individual plugin at the time that it was last modified via shelter storage and then use that to resolve conflicts per-plugin?
  • export modals not closing after success isn't great

@yellowsink
Copy link
Member

also on a fresh instance you can't pull due to loadedPlugins() being undefined but that's a really bizarre shelter-storage bug that (a) shouldn't occur, (b) is not your fault, its actually a bug in my import code!, and (c) i'm shocked that nothing else has had issues with before
this also could be a fluke, idrk. I should probably just use the storage directly instead of the signal lol

@taskylizard taskylizard requested a review from yellowsink April 11, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants