Skip to content

Optimize sap module to prevent high IO workload (bsc#1241455) #10296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

vzhestkov
Copy link
Contributor

What does this PR change?

In some deployments sap module could cause high IO workload in case of having large amount of directories inside the sap base path not related to sap instances.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite

  • Unit tests were updated

  • DONE

Links

Tracks: https://github.com/SUSE/spacewalk/issues/27037

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

@vzhestkov vzhestkov requested a review from a team as a code owner May 7, 2025 07:48
@vzhestkov vzhestkov requested review from m-czernek, wweellddeerr and meaksh and removed request for a team and m-czernek May 7, 2025 07:48
@vzhestkov vzhestkov changed the title Optimize sap module to prevent high IO workload Optimize sap module to prevent high IO workload (bsc#1241455) May 7, 2025
wweellddeerr
wweellddeerr previously approved these changes May 7, 2025
meaksh
meaksh previously approved these changes May 9, 2025
import os
import re

__virtualname__ = "sap"
__grains__ = {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be overridden by the loader but helps dev toos to know that it will be present and a dict. Would be nice to keep it.

@meaksh meaksh dismissed stale reviews from wweellddeerr and themself via 5120169 May 19, 2025 10:12
@meaksh meaksh requested a review from agraul May 19, 2025 10:12
@meaksh meaksh added the merge-candidate Meaning it needs to be considered for merging when the master branch is frozen label May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-candidate Meaning it needs to be considered for merging when the master branch is frozen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants