Skip to content

Docs/dashboard style updates #4255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: latest
Choose a base branch
from
Open

Conversation

rolfsmeds
Copy link
Contributor

Dashboard docs updates for vaadin/web-components#8962

Copy link

github-actions bot commented May 7, 2025

AI Language Review

In the reviewed files:

  1. dashboard-basic.ts: Ensure consistent use of custom CSS properties for widget styling. Currently, there is a mix of --vaadin-dashboard-item-rowspan and --vaadin-dashboard-widget-rowspan, as well as --vaadin-dashboard-item-colspan and --vaadin-dashboard-widget-colspan. They should be consistent across implementations for easier maintenance and clarity.

  2. Styling.adoc:

    • One entry has a duplicate CSS property for "Minimum column width" with different default values. It should be corrected to avoid confusion.
    • Under style variants, "Flow DashboardVariant" should consistently reference the dashboard variant names or styles for clarity. Consider standardizing this section for better readability.

Please address these issues to improve consistency and clarity in the code and documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants