Skip to content

Add styling properties to Avatar and Charts docs #4285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: latest
Choose a base branch
from
Open

Add styling properties to Avatar and Charts docs #4285

wants to merge 8 commits into from

Conversation

juuso-vaadin
Copy link
Contributor

No description provided.

@juuso-vaadin juuso-vaadin requested a review from rolfsmeds May 5, 2025 10:23
@github-actions GitHub Actions
Copy link

github-actions bot commented May 5, 2025 •
edited
Loading

AI Language Review

""

@juuso-vaadin juuso-vaadin changed the title Add color properties to Avatar styling documentation Add styling properties to Avatar and Charts docs May 5, 2025
rolfsmeds
rolfsmeds reviewed May 9, 2025
View reviewed changes
Copy link
Contributor

@rolfsmeds rolfsmeds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Background Color section on the Avatar Usage page would also make sense to move to the Styling tab (e.g. to the top). The user colors table could be in that section instead.

rolfsmeds
rolfsmeds requested changes May 9, 2025
View reviewed changes
articles/components/avatar/styling.adoc

|===

=== Color Properties
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
=== Color Properties
=== User Color Properties

articles/components/charts/styling/styling.adoc

|===

=== Contrasts
Copy link
Contributor

@rolfsmeds rolfsmeds May 9, 2025 •
edited by jouni
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
=== Contrasts
=== Other Chart Colors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolfsmeds rolfsmeds rolfsmeds requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juuso-vaadin @rolfsmeds @jouni