Skip to content

Add note and code example of disabling server modality #4404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: latest
Choose a base branch
from

Conversation

TatuLund
Copy link
Contributor

No description provided.

Copy link

AI Language Review

  • In the "Modality" section of the updated "Dialog" AsciiDoc file, review the new note about disabling server-side modality. The example provided should clearly explain the context and use case for this functionality. Ensure consistency in code formatting and explanations across the document.

  • Verify the proper indentation and alignment in the newly added Java code snippet under the "Modality" section to ensure clarity and readability.

@@ -199,6 +199,21 @@ endif::[]

Usually, non-modal dialogs should be draggable, so that the user can move them to access the user interface beneath.

[NOTE]
In some use cases you may want to disable the server side modality. This can be done after Dialog has been opened.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a new section (e.g., === Disabling Modality) instead of an admonition? What are those cases, could we offer an example? And why do I have to do it after the dialog has been opened?

@mshabarov mshabarov requested a review from mcollovati June 30, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants