MPR, add code example of how to use legacy component with modal dialog #4405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AI Language ReviewThe revised version of the document, "Limitations of MPR," includes a new section titled "Legacy Components & Modal Dialogs." This section provides guidance on handling legacy component events with the Dialog component by disabling server-side modality after the Dialog has opened. The code snippet provided is clear and accurately demonstrates how to achieve this. No improvements are necessary for this new section. |
mcollovati
reviewed
Jun 30, 2025
Comment on lines
+139
to
+143
| dialog.addOpenedChangeListener(e -> { | ||
| if (e.isOpened()) { | ||
| UI.getCurrent().setChildComponentModal(dialog, false); | ||
| } | ||
| }); |
There was a problem hiding this comment.
Could this be just dialog.setModal(false)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.