Skip to content

Conversation

@sosa-vaadin
Copy link
Contributor

There's an instruction for upgrading Control Center in which we recommend writing a password value into the terminal. This PR changes this insecure practice to use a reference to a file containing the password instead.

@sosa-vaadin sosa-vaadin self-assigned this Aug 28, 2025
@sosa-vaadin sosa-vaadin added the target/main cherry pick to main branch label Aug 28, 2025
@sosa-vaadin sosa-vaadin force-pushed the fix/password-in-console branch from 02907e6 to 1acd443 Compare August 28, 2025 07:51
@github-actions
Copy link

github-actions bot commented Aug 28, 2025

AI Language Review

The modifications in the Upgrading documentation file include important updates, specifically in the section about creating a secret for Control Center user credentials. A warning was added regarding the handling of sensitive information which is a significant improvement for security awareness. However, in the warning, the phrasing could be improved for clarity. The phrase "stored in the terminal command history" suggests avoiding storage, but it could be clearer by suggesting readers to use configuration files instead. The warning can be more precise and concise.

The line "Replace the example values with your own email address and the path to your password file." does not require changes as it accurately provides instruction.

No other modified lines require improvements.

@heruan heruan removed the target/main cherry pick to main branch label Sep 16, 2025
@heruan heruan closed this Oct 16, 2025
@heruan heruan reopened this Oct 16, 2025
@heruan heruan enabled auto-merge (squash) October 16, 2025 06:58
@CLAassistant
Copy link

CLAassistant commented Oct 26, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ heruan
❌ sosa-vaadin
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants