Highlight that vaadin-maven-plugin must always be defined after maven-compiler-plugin

[HerbertsVaadin]

Solves: #4432

Production Build:

Troubleshooting Production Mode:

[github-actions]

AI Language Review

• In the updated Production Build document, under the section Enabling Production Builds, a new warning note was added regarding ensuring the vaadin-maven-plugin executes after the maven-compiler-plugin. This note is relevant and aligns with best practices for plugin executions, ensuring that resources are correctly packaged for the production build. However, ensure that the language used is consistent and clear. For instance, consider updating "This note is relevant and aligns..." to "This ensures that resources are correctly packaged..." for clarity.

• In the updated Troubleshooting document, under the Common Issues section, a new issue about missing or not loaded frontend resources was added. This is a helpful addition for problem-solving. However, the phrase "This mean the value from one application..." should be corrected to "This means the value from one application...".

[HerbertsVaadin]

I disagree with AI language Review suggestions, would prefer a human review.

[mcollovati]

Looks good.
Perhaps we can mention that the same stands also the kotlin compiler plugin.

[HerbertsVaadin]

Looks good. Perhaps we can mention that the same stands also the kotlin compiler plugin.

@mcollovati Thanks for the review.
Is Kotlin common enough in Vaadin projects for it to warrant a mention? Maybe this applies to many other compiler plugins (not that I know of any, first time hearing of kotlin compiler plugin 😄 ), in which case, I wonder whether a more generic message is needed?

[mcollovati]

I think there are several users that are using Vaadin with Kotlin (and the DSL by @mvysny).
So I think it makes sense to add a note; could be just something link "The same applies for kotlin-maven-plugin or any other plugin that produces Vaadin related Java classes"

[HerbertsVaadin]

I think there are several users that are using Vaadin with Kotlin (and the DSL by @mvysny). So I think it makes sense to add a note; could be just something link "The same applies for kotlin-maven-plugin or any other plugin that produces Vaadin related Java classes"

Thanks @mcollovati , I have added that exact note now. Can you please confirm and merge if ok?

[vaadin-bot]

Hi @HerbertsVaadin and @mcollovati, when i performed cherry-pick to this commit to main, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick a7b800c
error: could not apply a7b800c... Highlight that vaadin-maven-plugin must always be defined after maven-compiler-plugin (#4676)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".