Fixing incorrect enum information and add alternatives #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lw64
requested changes
Mar 8, 2025
...writing-a-vapi-manually/04-00-recognizing-vala-semantics-in-c-code/04-02-enums-and-flags.rst
Outdated
Show resolved
Hide resolved
...writing-a-vapi-manually/04-00-recognizing-vala-semantics-in-c-code/04-02-enums-and-flags.rst
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current page https://docs.vala.dev/developer-guides/bindings/writing-a-vapi-manually/04-00-recognizing-vala-semantics-in-c-code/04-02-enums-and-flags.html
Indicates that an
enumcan inherit.According to a recent conversation issue in the Vala GitLab, this is incorrect, and
enuminheritance is not a thing:https://gitlab.gnome.org/GNOME/vala/-/issues/1595
So I removed this set of code and example, and instead added a valid alternative (just creating a separate
enumand casting to the original can work).I also added another
enumexample to deal with aliases, which when you invoke ato_string ()method can causeduplicate casecompiler errors in C, which can be solved viapublic const values. (Explained here https://gitlab.gnome.org/GNOME/vala/-/issues/1596)Hopefully this is a good addition to the docs :).