VALI-5458 :: Add Client Scripts Python Packages - #49
Merged
joaofogoncalves merged 5 commits intoMay 10, 2023
Merged
Conversation
ricardo-dematos
marked this pull request as ready for review
February 1, 2023 21:14
ricardo-dematos
requested review from
a team,
CamiloPT,
antonio-soares-altium,
goncalo-dias-altium and
joaofogoncalves
and removed request for
CamiloPT and
antonio-soares-altium
February 1, 2023 21:15
goncalo-dias-altium
left a comment
Contributor
There was a problem hiding this comment.
are these jira and slack packages really needed?
Contributor
Author
According to VALI-5458 , they were requested by --redacted--. @antonio-valispace can you provide more context, please? |
ricardo-dematos
force-pushed
the
VALI-5458-add-client-scripts-python-packages
branch
from
February 10, 2023 00:56
27e3d72 to
d904b47
Compare
Contributor
|
Pull Request is stale and will be closed in 14 days unless there is new activity |
|
For reference these are the added libs:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested Python packages added.
Commits
101a9f8Requested Python packages addedMore details about this issue at VALI-5458 — Jira