Adding bloom defrag hits and misses to info, added check these metrics get incremented in defrag test #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/test_bloom_defrag.py
Outdated
| @@ -101,3 +103,17 @@ def check_values_present(self, scale_names, num_items_inserted_per_object): | |||
| # All items should be present so we compare with an array of length num items where all items are 1 | |||
| expected_results = [1] * num_items | |||
| assert results == expected_results, f"Unexpected results for scale {scale}: {results}" | |||
|
|
|||
| def verfiy_bloom_defrag_metrics(self): | |||
There was a problem hiding this comment.
Actually, can we simply use this instead?
def info_obj(self):
"""Return a ValkeyInfo object for the current client info"""
return ValkeyInfo(self.info('all'))
You can add a custom function to accept a custom section name (MODULE, BF etc) and return the result. The caller site can access what they want from
self.info[<custom-metric>]
KarthikSubbarao
approved these changes
Dec 12, 2024
YueTang-Vanessa
approved these changes
Dec 12, 2024
KarthikSubbarao
force-pushed
the
unstable
branch
from
391d947 to
8b94c17
Compare
…s get incremented in defrag test Signed-off-by: zackcam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new section in info specifically for defrag. Added two new fields in this section of defrag hits and misses that are incremented in bloom_callback.
Added a check in defrag test to make sure these metrics are actually incremented