Code cleanup: removing unused dependencies in tests, removing digest file as it can be taken from a dependency and moving metric increments to after creates #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr removes unused dependencies from python integration tests and consolidates dependencies onto one line if possible
Removed the
digest.rs
file as the file was designed to be temporary until valkey-modulers released the digest changes which it has. Due to this updated the import of the digest to now be fromvalkey_module
Updated two order of incrementing metrics, in copy we now only increment the metrics after the create has gone through which means any unexpected failures on the create now won't cause issues with metrics. For decode moved the increment above the error check after create this now means if it gets dropped from the size validation the metrics will be accurate.
Had one clippy fix as well shown below:
Updated the command syntax in lib.rs to now follow the new args added for INFO and INSERT commands