Update LPOP and RPOP command description #308
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hwware <[email protected]>
hwware
force-pushed
the
update-lpop-rpop-md
branch
from
0ecfb42 to
9844df9
Compare
hwware
added a commit
to valkey-io/valkey
that referenced
this pull request
Jul 2, 2025
When I work on Slot-level metrics and info keysize feature, I read lpop and rpop command source code, the description confused me. I think these 2 commands description on website (https://valkey.io/commands/lpop/ and https://valkey.io/commands/rpop/) and json files were not updated after count argument was added. The return result could be one element only or up to count elements if the optional count argument is provided. It is related to valkey-doc pr valkey-io/valkey-doc#308 --------- Signed-off-by: hwware <[email protected]> Signed-off-by: Wen Hui <[email protected]> Co-authored-by: Viktor Söderqvist <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing descriptions only mention pop up one element and do not tell the user the list will be deleted if the last element is popped.
It is related to valkey pr valkey-io/valkey#2179