Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C#: Custom command for standalone client. #3335

Merged
merged 7 commits into from
Mar 14, 2025
Merged

C#: Custom command for standalone client. #3335

merged 7 commits into from
Mar 14, 2025

Conversation

Yury-Fridlyand
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand commented Mar 6, 2025 •
edited
Loading

Note: only simple strings are supported yet as arguments and as return type.

image

Issue link

This Pull Request is linked to issue (URL): #216

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Commits will be squashed upon merging.

@Yury-Fridlyand
poc
3f370ff 
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand
poc
79de7f3 
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand
Custom command for standalone.
d959152 
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand Yury-Fridlyand added the C# C# wrapper label Mar 6, 2025
@Yury-Fridlyand Yury-Fridlyand requested a review from Sa1Gur March 6, 2025 00:15
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner March 6, 2025 00:15
@Yury-Fridlyand
fix
c71db12 
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand
Rework memory freeing
e03c3c4 
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Mar 8, 2025
Merged
6 tasks
@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Mar 10, 2025
Open
85 tasks
jbrinkman
jbrinkman approved these changes Mar 12, 2025
View reviewed changes
Copy link
Collaborator

@jbrinkman jbrinkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Mar 13, 2025
Merged
edlng
edlng approved these changes Mar 13, 2025
View reviewed changes
Copy link
Collaborator

@edlng edlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix conflicts but LGTM

Sa1Gur
Sa1Gur approved these changes Mar 13, 2025
View reviewed changes
Copy link
Collaborator

@Sa1Gur Sa1Gur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yury-Fridlyand Yury-Fridlyand merged commit 8de167d into valkey-io:main Mar 14, 2025
15 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the csharp/yuryf-custom-command-standalone branch March 14, 2025 21:14
liorsve pushed a commit to liorsve/valkey-glide that referenced this pull request Mar 30, 2025
@Yury-Fridlyand @liorsve
C#: Custom command for standalone client. (valkey-io#3335)
26e43f2 
* Custom command for standalone.

Signed-off-by: Yury-Fridlyand <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrinkman jbrinkman jbrinkman approved these changes

@Sa1Gur Sa1Gur Sa1Gur approved these changes

@edlng edlng edlng approved these changes

Assignees
No one assigned
Labels
C# C# wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yury-Fridlyand @jbrinkman @Sa1Gur @edlng