Add installation link to download #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Madelyn Olson <[email protected]>
Signed-off-by: Madelyn Olson <[email protected]>
Signed-off-by: Madelyn Olson <[email protected]>
Signed-off-by: Madelyn Olson <[email protected]>
Signed-off-by: avifenesh <[email protected]>
|
@madolson @zuiderkwast Please review |
|
Good, but why is it rebased over #201? |
Yeah, it's really annoying. But if we modify the other PR, it will just be problems for your PR, so it's better keep it separate I think. I have posted a comment on Madelyn's PR. |
Signed-off-by: Madelyn Olson <[email protected]>
Signed-off-by: Madelyn Olson <[email protected]>
madolson
reviewed
Feb 4, 2025
madolson
reviewed
Feb 4, 2025
Signed-off-by: Madelyn Olson <[email protected]>
madolson
reviewed
Feb 4, 2025
Signed-off-by: Madelyn Olson <[email protected]>
madolson
changed the title
zuiderkwast
approved these changes
Feb 4, 2025
madolson
approved these changes
Feb 4, 2025
zuiderkwast
added a commit
to valkey-io/valkey-doc
that referenced
this pull request
Feb 5, 2025
Fixes #221 Related PR: valkey-io/valkey-io.github.io#202   --------- Signed-off-by: avifenesh <[email protected]> Signed-off-by: Avi Fenesh <[email protected]> Co-authored-by: avifenesh <[email protected]> Co-authored-by: Viktor Söderqvist <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
Issue valkey-io/valkey-doc#221
Rebased over #201
Related PR: valkey-io/valkey-doc#223
Changes looks:
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.