Refactor/commands page sidebar breadcrumbs #299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stockholmux
reviewed
Jul 11, 2025
There was a problem hiding this comment.
Would it be possible to have the split background colours extend to left and right? That way we get the readable width without the abrupt white background on left/right. What do you think @madolson?
See mockup:
Original:
- Refactor the commands page to include breadcrumb navigation and sidebar. Signed-off-by: Daniel Phillips <[email protected]>
- Implement sidebar search functionality for commands - Add no results message for sidebar search Signed-off-by: Daniel Phillips <[email protected]>
phiro56
force-pushed
the
refactor/commands-page-sidebar-breadcrumbs
branch
from
137be22 to
0474395
Compare
|
@stockholmux rebase with main fixed the expanded background 
|
This was referenced Aug 5, 2025
stockholmux
added a commit
that referenced
this pull request
Aug 5, 2025
…sue (#320) ### Description It looks like in #299 the sidebar code was copy/pasted from the command section into the command page. Both pages uses the global variable named `command_data_obj`, so when there wasn't a container explicitly from the command entry, it just used the one from the page. In this PR, I namespaced the variable name to fix the command names in the list. Additionally, I removed an unused global that sorted/grouped all the commands. I've also noticed that the build times have shot up after #299 to around 50 seconds - which is bonkers. Given the repetitious nature of this page element, this should be abstracted into a macro and/or cached during build. At time of writing there is 416 pages rendered in this section, each one has to open 416 + 4 (json files that index all the commands). That means that generating this sidebar adds 174,720 JSON file opens and parses. I will file a seperate issue to track. ### Issues Resolved #319 ### Check List - [x] Commits are signed per the DCO using `--signoff` By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License. Signed-off-by: Kyle J. Davis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor/commands page sidebar breadcrumbs
- Implement sidebar search functionality for commands
- Add no results message for sidebar search
(EDIT: Is this what you're doing with #293 ?)