Skip to content

pre-commit hooks for local validation#115

Open
sandeepkunusoth wants to merge 3 commits intovalkey-io:mainfrom
sandeepkunusoth:precommit-config-changes
Open

pre-commit hooks for local validation#115
sandeepkunusoth wants to merge 3 commits intovalkey-io:mainfrom
sandeepkunusoth:precommit-config-changes

Conversation

@sandeepkunusoth
Copy link
Copy Markdown
Member

@sandeepkunusoth sandeepkunusoth commented Mar 15, 2026

Fixes #111

Summary

Add local pre-commit validation support and contributor guidance for running checks before opening a PR.

Changes

  • Added .pre-commit-config.yaml
  • Documented pre-commit setup in CONTRIBUTING.md
  • Added PR template with a reminder to run pre-commit locally

Testing

Ran:

pre-commit run --all-files
generate code and manifests..............................................Passed
run go mod tidy..........................................................Passed
run golangci-lint........................................................Passed
Check for merge conflicts................................................Passed

Signed-off-by: Sandeep Kunusoth <sandeepkunsoth000@gmail.com>
Copy link
Copy Markdown
Member

@stockholmux stockholmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't reviewed this in detail, but I think we should add a checkbox to the PR template to ask the contributor if they're run pre-commit hooks.

Copy link
Copy Markdown
Collaborator

@jdheyburn jdheyburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed in weekly meeting 2026-03-20. It was suggested that we could include a checkbox on the PR template (do we have a PR template?) to verify that pre-commit checks have been executed - as a "nudge" or reminder that these checks have been completed.

That should be non-blocking though. I had a couple of comments on here though.

Signed-off-by: Sandeep Kunusoth <sandeepkunsoth000@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[dev] Provide pre-commit hooks for local validation

3 participants