pre-commit hooks for local validation#115
Open
sandeepkunusoth wants to merge 3 commits intovalkey-io:mainfrom
Open
pre-commit hooks for local validation#115sandeepkunusoth wants to merge 3 commits intovalkey-io:mainfrom
sandeepkunusoth wants to merge 3 commits intovalkey-io:mainfrom
Conversation
Signed-off-by: Sandeep Kunusoth <sandeepkunsoth000@gmail.com>
stockholmux
suggested changes
Mar 20, 2026
Member
stockholmux
left a comment
There was a problem hiding this comment.
I haven't reviewed this in detail, but I think we should add a checkbox to the PR template to ask the contributor if they're run pre-commit hooks.
jdheyburn
reviewed
Mar 20, 2026
Collaborator
jdheyburn
left a comment
There was a problem hiding this comment.
Discussed in weekly meeting 2026-03-20. It was suggested that we could include a checkbox on the PR template (do we have a PR template?) to verify that pre-commit checks have been executed - as a "nudge" or reminder that these checks have been completed.
That should be non-blocking though. I had a couple of comments on here though.
Signed-off-by: Sandeep Kunusoth <sandeepkunsoth000@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #111
Summary
Add local pre-commit validation support and contributor guidance for running checks before opening a PR.
Changes
.pre-commit-config.yamlpre-commitsetup inCONTRIBUTING.mdTesting
Ran: