-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update integration.yaml #170
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: ShAsHi <[email protected]>
Hey! Thanks for your contribution. Do I understand correctly that this PR targets #140 ? |
Yeah it resolves the issue ,previously Docker cache runs at midnight but it would'nt update it now I have added a timeout now it updates docker cahe |
Thanks! Your changes are quite large because you have your yaml formatter enabled on IDE. Could you disable it and force-push this branch so I could have a review of the intended changes? Also for me it seems like this change makes it so the docker cache rebuilds every run. Which might be fine, but originally I was thinking about doing it daily. The original idea of docker caching was done by @smeso, so I'll ask him what he had in mind :) |
This reverts commit b8698a9. Please enter the commit message for your changes. Lines starting with '#' will be ignored, and an empty message aborts the commit. On branch main Your branch is up to date with 'origin/main'. Changes to be committed:
Hey @NarmalaSk ! Is it expected that the PR is now empty? Or did you forget to push the changes? |
Yes Pr is empty now , I think my changes would change whole yaml file docker cache process , that's why Haven't pushed the changes |
Changing the caching process should be fine I guess, as long as the commit doesn't include the changes outside the scope of the problem :) Please tell me if you still are interested in fixing this issue. If you are not, I'll close this PR. |
Signed-off-by: ShAsHi <[email protected]>
now i have changed the integrations file you can look up to the code if it is ok merge else close this pr |
Sorry but it still includes many changes related to your lint. Additionally, you changed the title to be less descriptive of the changes themselves. I would like to thank you for your idea regarding caching! I'll have a look at the ways to implement it in our codebase as soon as I have time for it. If you struggle with your formatter, it's fine -- I can create a new PR later with only the change related to the docker cache. If this way of handling docker cache is relevant to our case, I'll mark you as the co-author of the changes :) |
Pull Request check-list
Description of change