Do not apply TNEF and TNEQ to the toaerrs #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mattpitkin
approved these changes
Apr 10, 2025
|
@vhaasteren Would it be useful if I created a new release version with this included? |
|
@mattpitkin I think that's useful, yes. NANOGrav and the IPTA are working hard on their new data releases at the moment. This particular bug has already caused some problems Thanks! |
|
Ok, no problem. I'll make a new release this evening. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in libstempo that applies TNEF and TNEQ parameters in the parfile to the toaerrs. If a T2EFAC or T2EQUAD is present in the parfile libstempo prevents tempo2 from updating the toaerrs, but for TNEQ and TNEF that does tot happen.
This PR updates libstempo so that it acts the same way: it simply sets the count of
self.psr[0].nTNEFandself.psr[0].nTNEQequal to zero.