-
Notifications
You must be signed in to change notification settings - Fork 103
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
### Description This fully removes the monorepo structure 🚝 💣 💥 Here's what was done: - move everything from `packages/mobile` to the repository root - file/folder names that were the same between these 2 folders, were merged (`package.json`, `scripts`, `jest.config.js`, etc) - adjust all paths accordingly (GitHub workflows, jest, metro, TS, Xcode, Android gradle files, etc) - remove lerna - remove some old unused scripts The app behavior should remain the same, since only paths were adjusted. For developers, the impact should be minimal, the main thing that changes is the working directory. No need to work in `packages/mobile` anymore. All scripts we had remain. ### Follow up While working on this, I came across 2 surprising issues: - `yarn install` [started failing on GH actions](https://github.com/valora-inc/wallet/runs/6351393671?check_suite_focus=true), while working locally, this is not the first time I see this and is caused by prepare steps of some dependencies which trigger `yarn install` multiple times while the initial `yarn install` is still running, yarnpkg/yarn#6312. As a workaround `yarn install` is retried to avoid this issue. We should see if newer versions of yarn handle this better. - The final app bundle size changed. It is caused by packages hoisting happening differently without the monorepo structure. It bundles multiple versions of the same package, because the ordering is different. It's mostly happening with `@celo/` packages + `bn.js`. The bundle size was initially 1.1 MB bigger, but I managed to decrease it by setting a yarn resolution for `bn.js`. We should take a further look at this next time we upgrade `@celo/` packages to avoid making the app bundle bigger than necessary. ### Tested - CI passes - Locally: - `yarn dev:ios` - `yarn dev:android` ### How others should test The wallet works as before. ### Related issues - Discussed on [Slack](https://valora-app.slack.com/archives/C025V1D6F3J/p1651251065521769). ### Backwards compatibility Yes
- Loading branch information
1 parent
ee94ebe
commit 2b28b69
Showing
1,461 changed files
with
964 additions
and
5,211 deletions.
There are no files selected for viewing
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,8 +4,6 @@ config.fatal = true | |
|
||
const branchName = new ShellString(env.BRANCH_NAME) | ||
|
||
cd('packages/mobile') | ||
|
||
// ensure that we are using ssh | ||
exec('git remote set-url origin [email protected]:valora-inc/wallet.git') | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,6 @@ | ||
#!/usr/bin/env bash | ||
set -euo pipefail | ||
|
||
cd packages/mobile | ||
|
||
# ensure that we are using ssh | ||
git remote set-url origin [email protected]:valora-inc/wallet.git | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.