Skip to content

fix(security): prevent path traversal in deleteFile (#75) #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vitalcheffe wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(security): prevent path traversal in deleteFile (#75) #85

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion models/files.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import { prisma } from "@/lib/db"
import { unlink } from "fs/promises"
import { safePathJoin, FILE_UPLOAD_PATH } from "@/lib/files"
import path from "path"
import { cache } from "react"
import { getTransactionById } from "./transactions"
Expand Down Expand Up @@ -74,7 +75,12 @@ export const deleteFile = async (id: string, userId: string) => {
}

try {
await unlink(path.resolve(path.normalize(file.path)))
// Use safePathJoin to prevent path traversal attacks (issue #75).
// file.path is relative to the user's uploads directory.
const user = await prisma.user.findUniqueOrThrow({ where: { id: userId } })
const userUploadsDir = safePathJoin(FILE_UPLOAD_PATH, user.email)
const fullPath = safePathJoin(userUploadsDir, file.path)
await unlink(fullPath)
} catch (error) {
console.error("Error deleting file:", error)
}
Expand Down