New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add firecrawl tests #6

Merged

vblagoje merged 1 commit into main from firecrawl_test

Dec 15, 2024

Owner

vblagoje commented Dec 15, 2024 •

edited

Loading

Why:

Fixes flaky test_firecrawl by handling specific API responses and improving test stability.

What:

Removed @pytest.mark.unstable from test_firecrawl.
Added handling for 402 Payment Required as a valid response.
Ensured subsequent logic runs only if initial scraping succeeds.

Notes:

Review error handling for HttpClientError and verify alignment with Firecrawl API behavior.


          Enable firecrawl tests

5bf0848

coveralls commented Dec 15, 2024

Pull Request Test Coverage Report for Build 12337853255

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 81.293%

Totals
Change from base Build 12337815901:	0.0%
Covered Lines:	352
Relevant Lines:	433

💛 - Coveralls

vblagoje merged commit e37dbce into main

9 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet