Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [placeholder-pdfkit010] Fix parsing issue #281 #282

Merged
merged 1 commit into from
Feb 22, 2025

Conversation

mazali01
Copy link
Contributor

@mazali01 mazali01 commented Feb 15, 2025

Fixing issue #281

Copy link
Owner

@vbuch vbuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only wonder if they can look like 12 0 R 13 0 R with any any whitespace in between. I'm a not rusty on this package already.

Thank you for the PR. Will try to get a release today/tomorrow.

@coveralls
Copy link

Coverage Status

coverage: 100.0% (+0.4%) from 99.636%
when pulling 2db7eb7 on mazali01:bugfix/field-ids-parsing
into 4235fe7 on vbuch:develop.

@vbuch vbuch merged commit 5f4a279 into vbuch:develop Feb 22, 2025
10 checks passed
@mazali01 mazali01 deleted the bugfix/field-ids-parsing branch February 22, 2025 15:27
@mazali01
Copy link
Contributor Author

Hi, Thanks for your notes on spaces inside the string value, I have created a PR: #283, You can check it out.
It addresses the spaces better in more robust way.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants