Alignment should be done on full assembly not shards#111
Closed
miraep8 wants to merge 7 commits into
Closed
Conversation
Contributor
|
Interesting! Well whether it changes the results or not, it should run markedly faster! |
Contributor
Author
|
Moving to archive this PR in favor of funcscan. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Realized that we were performing alignment on each shard, rather than on the full assembly. Given that some Cazyme genes may be somewhat degenerate, I am concerned that this may be causing us to over-inflate our RPM estimates. Will test a few samples with
isablbefore this is ready for merging.