Skip to content

chore(dev): remove dependency to tokio-util fork #23327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pront
Copy link
Member

@pront pront commented Jul 2, 2025

Summary

WIP - Needs updates to codecs.

Vector configuration

How did you test this PR?

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

Closes: #11257

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Some CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • cargo fmt --all
      • cargo clippy --workspace --all-targets -- -D warnings
      • cargo nextest run --workspace (alternatively, you can run cargo test --all)
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run cargo vdev build licenses to regenerate the license inventory and commit the changes (if any). More details here.

@github-actions github-actions bot added the domain: core Anything related to core crates i.e. vector-core, core-common, etc label Jul 2, 2025
@pront pront added domain: deps Anything related to Vector's dependencies no-changelog Changes in this PR do not need user-facing explanations in the release changelog labels Jul 2, 2025
@datadog-vectordotdev
Copy link

datadog-vectordotdev bot commented Jul 2, 2025

Datadog Report

Branch report: pront/remove-tokio-fork
Commit report: f6a4b69
Test service: vector

❌ 1 Failed (0 Known Flaky), 2695 Passed, 0 Skipped, 4m 4.25s Total Time

❌ Failed Tests (1)

  • codecs::decoding::decoder::tests::framed_read_recover_from_error - vector - Details

    Expand for error
     thread 'codecs::decoding::decoder::tests::framed_read_recover_from_error' panicked at src/codecs/decoding/decoder.rs:137:40
     
     thread 'codecs::decoding::decoder::tests::framed_read_recover_from_error' panicked at src/codecs/decoding/decoder.rs:137:40:
     called \`Option::unwrap()\` on a \`None\` value
     stack backtrace:
        0:     0x5602b0936220 - std::backtrace_rs::backtrace::libunwind::trace::h2b8934d68a0c74cb
                                    at /rustc/05f9846f893b09a1be1fc8560e33fc3c815cfecb/library/std/src/../../backtrace/src/backtrace/libunwind.rs:117:9
        1:     0x5602b0936220 - std::backtrace_rs::backtrace::trace_unsynchronized::h72d137991fa6eab8
                                    at /rustc/05f9846f893b09a1be1fc8560e33fc3c815cfecb/library/std/src/../../backtrace/src/backtrace/mod.rs:66:14
        2:     0x5602b0936220 - std::sys::backtrace::_print_fmt::h3e831e32e6da920b
     ...
    

@pront pront force-pushed the master branch 4 times, most recently from 1720078 to ffe54be Compare July 10, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: core Anything related to core crates i.e. vector-core, core-common, etc domain: deps Anything related to Vector's dependencies no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move back to upstream tokio
1 participant