-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(ci): use caching #23344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(ci): use caching #23344
Conversation
Co-authored-by: Pavlos Rontidis <[email protected]>
e44855a
to
098bf7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ci-run-all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces caching for the CI environment setup to speed up job execution and reduce redundant tool installations.
- Updated
prepare.sh
to installcargo-deb
v2.0.2. - Added a wrapper workflow (
.github/workflows/cache.yml
) that calls a composite cache action. - Integrated the cache action into the
int_tests
ande2e_tests
jobs inchanges.yml
.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
File | Description |
---|---|
scripts/environment/prepare.sh | Bumped cargo-deb install version from 2.0.0 to 2.0.2 |
.github/workflows/changes.yml | Added ensure-cache job and injected cache steps into tests |
.github/workflows/cache.yml | New wrapper workflow to invoke the cache action |
.github/actions/cache/action.yml | Composite action to pull, check, and bootstrap cached tools |
Comments suppressed due to low confidence (2)
.github/actions/cache/action.yml:41
- Using a magic dummy path (
/tmp/i-do-not-exist
) for cache existence checks can be confusing. Consider replacing it with a clearly named temporary directory or adding a comment to explain its purpose, improving readability and maintainability.
~/.rustup
.github/workflows/cache.yml:7
- [nitpick] The
on.push.paths
trigger covers changes toprepare.sh
and the cache action, but not the workflow definition itself. Consider adding'.github/workflows/cache.yml'
so updates to the wrapper workflow also trigger cache validation.
- './.github/actions/cache/**'
1720078
to
ffe54be
Compare
Summary
Vector configuration
How did you test this PR?
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changelog
label to this PR.References
Notes
@vectordotdev/vector
to reach out to us regarding this PR.pre-push
hook, please see this template.cargo fmt --all
cargo clippy --workspace --all-targets -- -D warnings
cargo nextest run --workspace
(alternatively, you can runcargo test --all
)git merge origin master
andgit push
.Cargo.lock
), pleaserun
cargo vdev build licenses
to regenerate the license inventory and commit the changes (if any). More details here.