Skip to content

fix(docker): detect nested pg0 data directories#1650

Merged
nicoloboschi merged 2 commits into
vectorize-io:mainfrom
xmh1011:fix/issue-1638-pg0-data-warning
May 25, 2026
Merged

fix(docker): detect nested pg0 data directories#1650
nicoloboschi merged 2 commits into
vectorize-io:mainfrom
xmh1011:fix/issue-1638-pg0-data-warning

Conversation

@xmh1011
Copy link
Copy Markdown
Contributor

@xmh1011 xmh1011 commented May 18, 2026

fix: #1638

@benfrank241
Copy link
Copy Markdown
Contributor

benfrank241 commented May 19, 2026

nice, thanks @xmh1011. cleanly closes #1638 and i like that the test asserts the warning still fires on real corruption. one small follow-up: test-start-all.sh isn't wired into CI today so it'll bitrot.

@xmh1011
Copy link
Copy Markdown
Contributor Author

xmh1011 commented May 20, 2026 •
edited
Loading

nice, thanks @xmh1011. cleanly closes #1638 and i like that the test asserts the warning still fires on real corruption. one small follow-up: test-start-all.sh isn't wired into CI today so it'll bitrot.

done @benfrank241

@benfrank241
Copy link
Copy Markdown
Contributor

benfrank241 commented May 22, 2026

leaving this for @nicoloboschi to review

@benfrank241 benfrank241 requested a review from nicoloboschi May 22, 2026 14:26
@nicoloboschi nicoloboschi merged commit 0b6bf53 into vectorize-io:main May 25, 2026
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicoloboschi nicoloboschi nicoloboschi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug Report: False-positive PG_VERSION corruption warning on restart when embedded pg0 data lives under nested instances/<name>/data

3 participants

@xmh1011 @benfrank241 @nicoloboschi