Skip to content

fix(mental-models): full refresh pending delta baselines#1684

Open
xmh1011 wants to merge 1 commit into
vectorize-io:mainfrom
xmh1011:fix/issue-1679-mental-model-initial-delta
Open

fix(mental-models): full refresh pending delta baselines#1684
xmh1011 wants to merge 1 commit into
vectorize-io:mainfrom
xmh1011:fix/issue-1679-mental-model-initial-delta

Conversation

@xmh1011
Copy link
Copy Markdown
Contributor

@xmh1011 xmh1011 commented May 21, 2026

Summary

  • Treat the mental-model creation placeholder Generating content... as pending content, not as a valid delta baseline.
  • Make the first delta-mode refresh fall back to full recall/synthesis so pre-existing scoped facts are considered.
  • Add a regression test asserting the placeholder path does not pass created_after or call the delta-merge LLM.

Closes #1679.

Tests

  • HINDSIGHT_API_LLM_PROVIDER=none uv run pytest tests/test_mental_model_delta.py::TestDeltaRefreshPlumbing -q
  • uv run ruff check hindsight_api/engine/memory_engine.py tests/test_mental_model_delta.py
  • uv run ty check hindsight_api/engine/memory_engine.py
  • ./scripts/hooks/lint.sh

@yugandhar-maram
Copy link
Copy Markdown

Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: delta-mode initial refresh skips all pre-existing facts when mental model is created after consolidation

2 participants