implement CloneFactory for 90% gas savings#10
Open
businessfriendlyusername wants to merge 12 commits intoveilco:masterfrom
Open
implement CloneFactory for 90% gas savings#10businessfriendlyusername wants to merge 12 commits intoveilco:masterfrom
businessfriendlyusername wants to merge 12 commits intoveilco:masterfrom
Conversation
Member
|
@businessfriendlyusername thank you for the PR, and sorry to miss this for such a long time. I'll use it as a template and will publish a fully-tested version of it soon. Appreciate the help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please for the love of god don't actually merge this, it's completely untested. I made a comment in your discord a few weeks ago about this and I need this PR for my non-existant resume so I can finally stop living off bitcoin money from 2016. Anyways The CloneFactory contract is a way to reduce gas costs by over 90% when cloning existing contracts. I added changed some code in VirtualAugurShare and VirtualAugurShareFactory so that it now uses CloneFactory. I also added a cool little vanity address optimization. All of my changes are outlined in the DEV_README file I included. I'm sure you guys would have done this anyway eventually, but like I said my resume doesn't exist so here it is :D