-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
async/await support and other changes for meteor@3 #895
Open
dr-dimitru
wants to merge
63
commits into
dev
Choose a base branch
from
migration-branch/3.0
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 v2.2.0 __Breaking Changes__ -⚠️ Changes in `namingFunction`, — now naming function acts the same on the Client and Server, upon insert, load, and write. Test your implementation with changed logic. Output of Server function supersedes Client's function output __Changes__ - 📔 Merge #843 and fix #820, thanks to @Prinzhorn - 📔 Documentation refactoring focused on examples and its simplifications - 👨💻 Support nested custom path returned from `namingFunction` - 👨💻 Fix `namingFunction` behavior on Client and Server in upload, load, and write methods, closing #842; Thanks to @chrschae - 👷♂️ Now library exports its helpers `import { FilesCollection, helpers };` - 👷♂️ Add `.meteorignore` to minimize package's footprint
📦 v2.3.0 __New features:__ - ✨ `opts.sanitize` method, read more in [*Constructor* docs](https://github.com/veliovgroup/Meteor-Files/blob/master/docs/constructor.md); Thanks to @xet7 and @mfilser __Other Changes:__ - 👷♂️ Minor codebase enhancements and cleanups
v2.3.1 __Changes:__ - 👨💻 Improve `createIndex` helper - 👨💻 Improve error output when FileSystem destination not writable; Related to #857, thanks to @Leekao - 🐞 Fix custom `allowedOrigins` option for CORS; Closing #850, thanks to @djlogan2; __Notes:__ - 👨🔬 Tested with latest release of `[email protected]`
📔 Improve AWS S3 documentation
📦 v2.3.2 - 👨💻 Potential fix for #857 (windows)
👷♂️ Update .eslintrc
📦 v2.3.3 __Major changes:__ - no __Changes:__ - 👨🔧 Fixed #870, thanks to @Gobliins - 🤝 Compatibility with `[email protected]`
Make onBeforeUpload async compliant
Meteor 3.0: Adding Async Methods to server
@jankapunkt created this PR to track changes inherited from #884 |
- `removeAsync` for Client and Server - `removeAsync` returns `Promise<number>` - `remove` now returns `error, number`
- returns `uploadInstance`, same as `.insert` method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.