ci: pin GitHub Actions to commit SHAs (FE-4376)#155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Pin all floating GitHub Actions refs in this repo to full commit SHAs (with
# versioncomments), across workflow files and compositeaction.ymlfiles. SHAs are the exact commits each tag/branch currently resolves to.Why
Part of the org-wide GitHub Actions hardening effort (FE-4376). The
drift-labsorg now hassha_pinning_required: trueand is moving offAllow all actionsto a selected-actions allow-list. Floating refs (@v1,@master, …) must be pinned to full SHAs first so neither the pin-enforcement policy nor the allow-list flip breaks CI. Pinning to a SHA is the actual supply-chain defense (a mutable@master/tag can be moved by a compromised maintainer).Scope
Action ref pins only — no logic changes. Behavior preserved (e.g.
dtolnay/rust-toolchain@stablepins to the stable-branch commit whoseaction.ymlstill defaults to the stable channel).