Skip to content

SSAST-10519 Add option to collect debug data#92

Merged
davdres merged 10 commits into
developfrom
feature/SSAST-10519
Jun 2, 2025
Merged

SSAST-10519 Add option to collect debug data#92
davdres merged 10 commits into
developfrom
feature/SSAST-10519

Conversation

@davdres
Copy link
Copy Markdown
Collaborator

@davdres davdres commented May 5, 2025

No description provided.

@davdres davdres requested a review from NinjaLikesCheez May 5, 2025 22:37
@davdres davdres marked this pull request as draft May 6, 2025 00:28
@davdres davdres self-assigned this May 6, 2025
@davdres davdres removed the request for review from NinjaLikesCheez May 6, 2025 00:28
Comment thread Sources/GenIR/DebugData.swift Outdated
@davdres davdres marked this pull request as ready for review May 6, 2025 18:06
@davdres davdres requested a review from NinjaLikesCheez May 6, 2025 18:07
Copy link
Copy Markdown
Collaborator

@NinjaLikesCheez NinjaLikesCheez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting some changes - please let me know if you have any questions about my comments!

Comment thread Sources/GenIR/GenIR.swift Outdated
Comment thread Sources/GenIR/DebugData.swift Outdated
Comment thread Sources/GenIR/DebugData.swift Outdated
Comment thread Sources/GenIR/DebugData.swift Outdated
Comment thread Sources/GenIR/DebugData.swift Outdated
Comment thread Sources/GenIR/DebugData.swift Outdated
Comment thread Sources/GenIR/DebugData.swift Outdated
Comment thread Sources/LogHandlers/Sources/LogHandlers/FileLogHandler.swift Outdated
Comment thread Sources/LogHandlers/Sources/LogHandlers/FileLogHandler.swift Outdated
Comment thread Sources/LogHandlers/Sources/LogHandlers/GenIRLoggingDefinition.swift Outdated
@davdres davdres marked this pull request as draft May 10, 2025 20:51
@davdres davdres marked this pull request as ready for review May 14, 2025 20:18
@davdres davdres requested a review from NinjaLikesCheez May 27, 2025 22:45
Comment thread Sources/GenIR/DebugData.swift Outdated
Comment thread Sources/GenIR/DebugData.swift Outdated
@davdres davdres requested a review from NinjaLikesCheez May 28, 2025 19:18
Copy link
Copy Markdown
Collaborator

@NinjaLikesCheez NinjaLikesCheez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change to remove throws keyword since the init no longer throws.

Comment thread Sources/GenIR/DebugData.swift
Comment thread Sources/GenIR/GenIR.swift
@NinjaLikesCheez NinjaLikesCheez self-requested a review June 2, 2025 14:54
@NinjaLikesCheez NinjaLikesCheez dismissed their stale review June 2, 2025 14:55

Review was wrong.

@davdres davdres merged commit d7fb8ef into develop Jun 2, 2025
2 checks passed
@davdres davdres deleted the feature/SSAST-10519 branch June 4, 2025 15:26
davdres added a commit that referenced this pull request Sep 19, 2025
* Handle targets with same name but in different projects
* Issue #81 log unrequired targets instead of failing.
* Issue #81 log PIF location & missing commands.
* Issue #81 PIF workspace sort
* Issue #81 Update version; add some logging

Co-authored-by: NinjaLikesCheez <NinjaLikesCheez@users.noreply.github.com>

* Update PIF/Sources/PIFSupport/PIFSupport.swift

Co-authored-by: NinjaLikesCheez <NinjaLikesCheez@users.noreply.github.com>

* Issue #81 Address linter & review issues.

* Issue #81 Test unwrap of optional pif cache location.

* ENG-55520: On sourceTree decode error, log & continue (#88)

ENG-55520
* On sourceTree decode error, log & continue
* SourceTree: refactor to class

* SENG-9588 remove development release (#90)

* SENG-9588 remove development release

* SSAST-10500 Warn if multiple builds in xcode log (#91)

* SSAST-10519 Add option to capture debug data (#92)

A --capture option has been added to collect diagnostic data into a debug-data sub-folder of the IR directory. What data has been captured is written to the Gen-IR log.

* SSAST-10900 Update help for debug data capture. (#93)

* SSAST-11687 fix type fixing merge conflicts

* SSAST-11687 fix swiftlint error-no error locally

* Update build.yml

Update to match my local version.  The tests run locally.

---------

Co-authored-by: bmxav <5422569+bmxav@users.noreply.github.com>
Co-authored-by: NinjaLikesCheez <NinjaLikesCheez@users.noreply.github.com>
davdres added a commit that referenced this pull request Jan 5, 2026
* Release/0.5.2 (#87)

* Issue #81 log unrequired targets instead of failing.
* Issue #81 PIF workspace sort

* Release/0.5.3 (#89)

ENG-55520
* On sourceTree decode error, log & continue
* SourceTree: refactor to class

* Release/0.5.4 (#95)

* Handle targets with same name but in different projects
* Issue #81 log unrequired targets instead of failing.
* Issue #81 log PIF location & missing commands.
* Issue #81 PIF workspace sort
* Issue #81 Update version; add some logging

Co-authored-by: NinjaLikesCheez <NinjaLikesCheez@users.noreply.github.com>

* Update PIF/Sources/PIFSupport/PIFSupport.swift

Co-authored-by: NinjaLikesCheez <NinjaLikesCheez@users.noreply.github.com>

* Issue #81 Address linter & review issues.

* Issue #81 Test unwrap of optional pif cache location.

* ENG-55520: On sourceTree decode error, log & continue (#88)

ENG-55520
* On sourceTree decode error, log & continue
* SourceTree: refactor to class

* SENG-9588 remove development release (#90)

* SENG-9588 remove development release

* SSAST-10500 Warn if multiple builds in xcode log (#91)

* SSAST-10519 Add option to capture debug data (#92)

A --capture option has been added to collect diagnostic data into a debug-data sub-folder of the IR directory. What data has been captured is written to the Gen-IR log.

* SSAST-10900 Update help for debug data capture. (#93)

* SSAST-11687 fix type fixing merge conflicts

* SSAST-11687 fix swiftlint error-no error locally

* Update build.yml

Update to match my local version.  The tests run locally.

---------

Co-authored-by: bmxav <5422569+bmxav@users.noreply.github.com>
Co-authored-by: NinjaLikesCheez <NinjaLikesCheez@users.noreply.github.com>

* Release/1.0.0 (#98)

* Handle targets with same name but in different projects

* Ignore test bundles when generating bitcode

* Issue #81 log unrequired targets instead of failing.

* Issue #81 PIF workspace sort

ENG-55520
* On sourceTree decode error, log & continue
* SourceTree: refactor to class

* SENG-9588 remove development release

* SSAST-10500 Warn if multiple builds in xcode log (#91)

* SSAST-10519 A --capture option has been added to collect diagnostic data into a debug-data sub-folder of the IR directory. What data has been captured is written to the Gen-IR log.

* Install instructions cannot be executed as is, improve install instructions to make them executable

* Feature/ssast 10888 (#96)

* SSAST-10888 don't copy dependent modules but save them for pp to reconstruct.

---------

Co-authored-by: bmxav <5422569+bmxav@users.noreply.github.com>
Co-authored-by: NinjaLikesCheez <NinjaLikesCheez@users.noreply.github.com>
Co-authored-by: Boy Baukema <bbaukema@veracode.com>

---------

Co-authored-by: Bryan Xavier <5422569+bmxav@users.noreply.github.com>
Co-authored-by: NinjaLikesCheez <NinjaLikesCheez@users.noreply.github.com>
Co-authored-by: Boy Baukema <bbaukema@veracode.com>
davdres added a commit that referenced this pull request Jan 8, 2026
* Handle targets with same name but in different projects

* Ignore test bundles when generating bitcode

* Update build.yml

* Update build.yml

* Update build.yml

* Update build.yml

* Issue #81 log unrequired targets instead of failing.

* Issue #81 log PIF location & missing commands.

* Issue #81 PIF workspace sort

* Issue #81 resolve lint error.

* Issue #81 Update version; add some logging

* Update PIF/Sources/PIFSupport/PIF.swift

Co-authored-by: NinjaLikesCheez <NinjaLikesCheez@users.noreply.github.com>

* Update PIF/Sources/PIFSupport/PIFSupport.swift

Co-authored-by: NinjaLikesCheez <NinjaLikesCheez@users.noreply.github.com>

* Issue #81 Address linter & review issues.

* Issue #81 Test unwrap of optional pif cache location.

* ENG-55520: On sourceTree decode error, log & continue (#88)

ENG-55520
* On sourceTree decode error, log & continue
* SourceTree: refactor to class

* SENG-9588 remove development release (#90)

* SENG-9588 remove development release

* SSAST-10500 Warn if multiple builds in xcode log (#91)

* SSAST-10519 Add option to capture debug data (#92)

A --capture option has been added to collect diagnostic data into a debug-data sub-folder of the IR directory. What data has been captured is written to the Gen-IR log.

* SSAST-10900 Update help for debug data capture. (#93)

* Install instructions cannot be executed as is, improve install instructions to make them executable

* Feature/ssast 10888 (#96)

* release/0.5.4 changes merged into main but not on develop

* SSAST-10888 don't copy dependent modules but save them for pp to reconstruct.

* SSAST-13151 Use info logging to give user a progress indication. (#99)

* Release/1.0.1 (#101)

* Release/0.5.2 (#87)

* Issue #81 log unrequired targets instead of failing.
* Issue #81 PIF workspace sort

* Release/0.5.3 (#89)

ENG-55520
* On sourceTree decode error, log & continue
* SourceTree: refactor to class

* Release/0.5.4 (#95)

* Handle targets with same name but in different projects
* Issue #81 log unrequired targets instead of failing.
* Issue #81 log PIF location & missing commands.
* Issue #81 PIF workspace sort
* Issue #81 Update version; add some logging

Co-authored-by: NinjaLikesCheez <NinjaLikesCheez@users.noreply.github.com>

* Update PIF/Sources/PIFSupport/PIFSupport.swift

Co-authored-by: NinjaLikesCheez <NinjaLikesCheez@users.noreply.github.com>

* Issue #81 Address linter & review issues.

* Issue #81 Test unwrap of optional pif cache location.

* ENG-55520: On sourceTree decode error, log & continue (#88)

ENG-55520
* On sourceTree decode error, log & continue
* SourceTree: refactor to class

* SENG-9588 remove development release (#90)

* SENG-9588 remove development release

* SSAST-10500 Warn if multiple builds in xcode log (#91)

* SSAST-10519 Add option to capture debug data (#92)

A --capture option has been added to collect diagnostic data into a debug-data sub-folder of the IR directory. What data has been captured is written to the Gen-IR log.

* SSAST-10900 Update help for debug data capture. (#93)

* SSAST-11687 fix type fixing merge conflicts

* SSAST-11687 fix swiftlint error-no error locally

* Update build.yml

Update to match my local version.  The tests run locally.

---------

Co-authored-by: bmxav <5422569+bmxav@users.noreply.github.com>
Co-authored-by: NinjaLikesCheez <NinjaLikesCheez@users.noreply.github.com>

* Release/1.0.0 (#98)

* Handle targets with same name but in different projects

* Ignore test bundles when generating bitcode

* Issue #81 log unrequired targets instead of failing.

* Issue #81 PIF workspace sort

ENG-55520
* On sourceTree decode error, log & continue
* SourceTree: refactor to class

* SENG-9588 remove development release

* SSAST-10500 Warn if multiple builds in xcode log (#91)

* SSAST-10519 A --capture option has been added to collect diagnostic data into a debug-data sub-folder of the IR directory. What data has been captured is written to the Gen-IR log.

* Install instructions cannot be executed as is, improve install instructions to make them executable

* Feature/ssast 10888 (#96)

* SSAST-10888 don't copy dependent modules but save them for pp to reconstruct.

---------

Co-authored-by: bmxav <5422569+bmxav@users.noreply.github.com>
Co-authored-by: NinjaLikesCheez <NinjaLikesCheez@users.noreply.github.com>
Co-authored-by: Boy Baukema <bbaukema@veracode.com>

---------

Co-authored-by: Bryan Xavier <5422569+bmxav@users.noreply.github.com>
Co-authored-by: NinjaLikesCheez <NinjaLikesCheez@users.noreply.github.com>
Co-authored-by: Boy Baukema <bbaukema@veracode.com>

---------

Co-authored-by: bmxav <5422569+bmxav@users.noreply.github.com>
Co-authored-by: NinjaLikesCheez <NinjaLikesCheez@users.noreply.github.com>
Co-authored-by: Boy Baukema <bbaukema@veracode.com>
davdres added a commit that referenced this pull request Mar 30, 2026
* Handle targets with same name but in different projects

* Ignore test bundles when generating bitcode

* Update build.yml

* Update build.yml

* Update build.yml

* Update build.yml

* Issue #81 log unrequired targets instead of failing.

* Issue #81 log PIF location & missing commands.

* Issue #81 PIF workspace sort

* Issue #81 resolve lint error.

* Issue #81 Update version; add some logging

* Update PIF/Sources/PIFSupport/PIF.swift

Co-authored-by: NinjaLikesCheez <NinjaLikesCheez@users.noreply.github.com>

* Update PIF/Sources/PIFSupport/PIFSupport.swift

Co-authored-by: NinjaLikesCheez <NinjaLikesCheez@users.noreply.github.com>

* Issue #81 Address linter & review issues.

* Issue #81 Test unwrap of optional pif cache location.

* ENG-55520: On sourceTree decode error, log & continue (#88)

ENG-55520
* On sourceTree decode error, log & continue
* SourceTree: refactor to class

* SENG-9588 remove development release (#90)

* SENG-9588 remove development release

* SSAST-10500 Warn if multiple builds in xcode log (#91)

* SSAST-10519 Add option to capture debug data (#92)

A --capture option has been added to collect diagnostic data into a debug-data sub-folder of the IR directory. What data has been captured is written to the Gen-IR log.

* SSAST-10900 Update help for debug data capture. (#93)

* Install instructions cannot be executed as is, improve install instructions to make them executable

* Feature/ssast 10888 (#96)

* release/0.5.4 changes merged into main but not on develop

* SSAST-10888 don't copy dependent modules but save them for pp to reconstruct.

* SSAST-13151 Use info logging to give user a progress indication. (#99)

* Release/1.0.1 (#101)

* Release/0.5.2 (#87)

* Issue #81 log unrequired targets instead of failing.
* Issue #81 PIF workspace sort

* Release/0.5.3 (#89)

ENG-55520
* On sourceTree decode error, log & continue
* SourceTree: refactor to class

* Release/0.5.4 (#95)

* Handle targets with same name but in different projects
* Issue #81 log unrequired targets instead of failing.
* Issue #81 log PIF location & missing commands.
* Issue #81 PIF workspace sort
* Issue #81 Update version; add some logging

Co-authored-by: NinjaLikesCheez <NinjaLikesCheez@users.noreply.github.com>

* Update PIF/Sources/PIFSupport/PIFSupport.swift

Co-authored-by: NinjaLikesCheez <NinjaLikesCheez@users.noreply.github.com>

* Issue #81 Address linter & review issues.

* Issue #81 Test unwrap of optional pif cache location.

* ENG-55520: On sourceTree decode error, log & continue (#88)

ENG-55520
* On sourceTree decode error, log & continue
* SourceTree: refactor to class

* SENG-9588 remove development release (#90)

* SENG-9588 remove development release

* SSAST-10500 Warn if multiple builds in xcode log (#91)

* SSAST-10519 Add option to capture debug data (#92)

A --capture option has been added to collect diagnostic data into a debug-data sub-folder of the IR directory. What data has been captured is written to the Gen-IR log.

* SSAST-10900 Update help for debug data capture. (#93)

* SSAST-11687 fix type fixing merge conflicts

* SSAST-11687 fix swiftlint error-no error locally

* Update build.yml

Update to match my local version.  The tests run locally.

---------

Co-authored-by: bmxav <5422569+bmxav@users.noreply.github.com>
Co-authored-by: NinjaLikesCheez <NinjaLikesCheez@users.noreply.github.com>

* Release/1.0.0 (#98)

* Handle targets with same name but in different projects

* Ignore test bundles when generating bitcode

* Issue #81 log unrequired targets instead of failing.

* Issue #81 PIF workspace sort

ENG-55520
* On sourceTree decode error, log & continue
* SourceTree: refactor to class

* SENG-9588 remove development release

* SSAST-10500 Warn if multiple builds in xcode log (#91)

* SSAST-10519 A --capture option has been added to collect diagnostic data into a debug-data sub-folder of the IR directory. What data has been captured is written to the Gen-IR log.

* Install instructions cannot be executed as is, improve install instructions to make them executable

* Feature/ssast 10888 (#96)

* SSAST-10888 don't copy dependent modules but save them for pp to reconstruct.

---------

Co-authored-by: bmxav <5422569+bmxav@users.noreply.github.com>
Co-authored-by: NinjaLikesCheez <NinjaLikesCheez@users.noreply.github.com>
Co-authored-by: Boy Baukema <bbaukema@veracode.com>

---------

Co-authored-by: Bryan Xavier <5422569+bmxav@users.noreply.github.com>
Co-authored-by: NinjaLikesCheez <NinjaLikesCheez@users.noreply.github.com>
Co-authored-by: Boy Baukema <bbaukema@veracode.com>

* SSAST-11722 Log error and continue on TargetDependency decode error (#103)

* SSAST-11722 Log error and continue on TargetDependency decode error

* SSAST-11722 Add report action

* SSAST-12047 change targetGUID to optional.

---------

Co-authored-by: bmxav <5422569+bmxav@users.noreply.github.com>
Co-authored-by: NinjaLikesCheez <NinjaLikesCheez@users.noreply.github.com>
Co-authored-by: Boy Baukema <bbaukema@veracode.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants