fix state load failing when no browser is running#527
Merged
Conversation
`state load` always fails with "Cannot load state while browser is running" even when no browser is running, making the command completely unusable (#526). The daemon's auto-launch logic starts a browser before `state_load` gets to handle the command. This adds `state_load` to the exclusion list alongside `launch` and `close`, so `handleStateLoad` can perform its own launch with the state file.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Wow that was fast! Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
state loadalways fails with "Cannot load state while browser is running" even when no browser is running, making the command completely unusable (#526).The daemon's auto-launch logic starts a browser before
state_loadgets to handle the command. This addsstate_loadto the exclusion list alongsidelaunchandclose, sohandleStateLoadcan perform its own launch with the state file.