Skip to content

fix remote debugging #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ctate merged 2 commits into from
Feb 23, 2026
Merged

fix remote debugging #533

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f2200b
fix remote debugging
ctate Feb 23, 2026
095b90a
debug log
ctate Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 27 additions & 15 deletions src/browser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1363,7 +1363,10 @@ export class BrowserManager {
* Connect to a running browser via CDP (Chrome DevTools Protocol)
* @param cdpEndpoint Either a port number (as string) or a full WebSocket URL (ws:// or wss://)
*/
private async connectViaCDP(cdpEndpoint: string | undefined): Promise<void> {
private async connectViaCDP(
cdpEndpoint: string | undefined,
options?: { timeout?: number }
): Promise<void> {
if (!cdpEndpoint) {
throw new Error('CDP endpoint is required for CDP connection');
}
Expand All @@ -1388,14 +1391,16 @@ export class BrowserManager {
cdpUrl = `http://localhost:${cdpEndpoint}`;
}

const browser = await chromium.connectOverCDP(cdpUrl).catch(() => {
throw new Error(
`Failed to connect via CDP to ${cdpUrl}. ` +
(cdpUrl.includes('localhost')
? `Make sure the app is running with --remote-debugging-port=${cdpEndpoint}`
: 'Make sure the remote browser is accessible and the URL is correct.')
);
});
const browser = await chromium
.connectOverCDP(cdpUrl, { timeout: options?.timeout })
.catch(() => {
throw new Error(
`Failed to connect via CDP to ${cdpUrl}. ` +
(cdpUrl.includes('localhost')
? `Make sure the app is running with --remote-debugging-port=${cdpEndpoint}`
: 'Make sure the remote browser is accessible and the URL is correct.')
);
});

// Validate and set up state, cleaning up browser connection if anything fails
try {
Expand Down Expand Up @@ -1521,20 +1526,27 @@ export class BrowserManager {
for (const dir of userDataDirs) {
const activePort = this.readDevToolsActivePort(dir);
if (activePort) {
// Verify the port is actually responding
// Try HTTP discovery first (works with --remote-debugging-port mode)
const wsUrl = await this.probeDebugPort(activePort.port);
if (wsUrl) {
// Connect using the discovered WebSocket URL
await this.connectViaCDP(wsUrl);
return;
}
// Port from file exists but not responding; try HTTP endpoint directly
const httpUrl = `http://127.0.0.1:${activePort.port}`;
// HTTP probe failed -- Chrome M144+ chrome://inspect remote debugging uses a
// WebSocket-only server with no HTTP endpoints. Connect using the WebSocket
// path read directly from DevToolsActivePort.
const directWsUrl = `ws://127.0.0.1:${activePort.port}${activePort.wsPath}`;
try {
await this.connectViaCDP(httpUrl);
if (process.env.AGENT_BROWSER_DEBUG === '1') {
console.error(
`[DEBUG] HTTP probe failed on port ${activePort.port}, ` +
`attempting direct WebSocket connection to ${directWsUrl}`
);
}
await this.connectViaCDP(directWsUrl, { timeout: 60_000 });
return;
} catch {
// Port listed but not connectable, try next directory
// Direct WebSocket also failed, try next directory
}
}
}
Expand Down