fix: resolve Windows daemon connection issues#542
Open
dongliang wants to merge 1 commit intovercel-labs:mainfrom
Open
fix: resolve Windows daemon connection issues#542dongliang wants to merge 1 commit intovercel-labs:mainfrom
dongliang wants to merge 1 commit intovercel-labs:mainfrom
Conversation
1. [Strip \?\ path prefix]: Strip the extended-length path prefix from canonicalized exe path on Windows, as Node.js cannot handle \?\ prefixed paths 2. [Platform-specific daemon error message]: Replace hardcoded socket path in daemon startup error with platform-aware info — show TCP port on Windows, socket path on Unix
Contributor
|
@dongliang is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows,
std::path::Path::canonicalize()returns extended-length paths with\\?\prefix. Node.js cannot handle these paths, causing the daemon to fail to start.This PR fixes two issues in
cli/src/connection.rs:\\?\prefix from canonicalized exe path on Windows, so Node.js can correctly resolve the daemon binary