Skip to content

Conversation

ctate
Copy link
Collaborator

@ctate ctate commented Oct 11, 2025

No description provided.

Copy link

vercel bot commented Oct 11, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
coding-agent-platform Ready Ready Preview Comment Oct 11, 2025 7:07pm

className={`fixed bottom-0 right-0 z-10 bg-background ${isResizing || isSidebarResizing ? '' : 'transition-all duration-300 ease-in-out'}`}
style={{
left: isSidebarOpen ? 'var(--sidebar-width)' : '0px',
left: '0px',
Copy link

@vercel vercel bot Oct 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
left: '0px',
left: 'calc(var(--sidebar-width) * var(--sidebar-open))',

The LogsPane is now always positioned with left: '0px', which causes it to be partially obscured by the sidebar on desktop when the sidebar is open.

View Details

Analysis

LogsPane overlaps with sidebar due to fixed left positioning

What fails: LogsPane component (components/logs-pane.tsx:137) always uses left: '0px' positioning, causing it to be partially covered by the sidebar (z-index 40) when the sidebar is open on desktop.

How to reproduce:

  1. Open the application on desktop (width >= 1024px)
  2. Open the sidebar (Cmd/Ctrl+B or click sidebar toggle)
  3. Navigate to a task with logs
  4. Observe the LogsPane at the bottom

Result: The left portion of the LogsPane (approximately 300px) is hidden behind the sidebar. The collapse/expand button and "Logs" label at px-3 are not visible or interactive.

Expected: LogsPane should start at the right edge of the sidebar when it's open (similar to how main content adjusts with marginLeft in app-layout.tsx:361).

Root cause: Commit 07308e7 removed isSidebarOpen from LogsPane's props and changed positioning from left: isSidebarOpen ? 'var(--sidebar-width)' : '0px' to left: '0px'.

Fix: Use CSS calc with existing CSS variables: left: 'calc(var(--sidebar-width) * var(--sidebar-open))' which evaluates to 300px when open (300 * 1) and 0px when closed (300 * 0).

Copy link

@vercel vercel bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 Build Fix:

Fixed TypeScript compilation errors: session.user type mismatch in user.tsx and array type assignment issue in task-form.tsx.

📝 Patch Details
diff --git a/components/auth/user.tsx b/components/auth/user.tsx
index f952a71..387a71b 100644
--- a/components/auth/user.tsx
+++ b/components/auth/user.tsx
@@ -18,7 +18,7 @@ export function User(props: { user?: Session['user'] | null; authProvider?: Sess
   // Only update from session after initialization is complete
   useEffect(() => {
     if (initialized) {
-      setUser(session.user)
+      setUser(session.user ?? null)
       setAuthProvider(session.authProvider ?? 'vercel')
     }
   }, [initialized, session.user, session.authProvider])
diff --git a/components/task-form.tsx b/components/task-form.tsx
index 6c6e4f2..18d6946 100644
--- a/components/task-form.tsx
+++ b/components/task-form.tsx
@@ -315,7 +315,7 @@ export function TaskForm({
 
   // Check if user has required API keys for selected agent
   const checkApiKeyRequirements = (): boolean => {
-    let requirements = AGENT_API_KEY_REQUIREMENTS[selectedAgent as keyof typeof AGENT_API_KEY_REQUIREMENTS]
+    let requirements: readonly string[] = AGENT_API_KEY_REQUIREMENTS[selectedAgent as keyof typeof AGENT_API_KEY_REQUIREMENTS]
 
     // For opencode, determine requirements based on selected model
     if (selectedAgent === 'opencode') {

@ctate ctate merged commit 078405a into main Oct 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant