fix: fail fast on ssh passphrase - instead of 60 second hang#910
Open
huntharo wants to merge 1 commit intovercel-labs:mainfrom
Open
fix: fail fast on ssh passphrase - instead of 60 second hang#910huntharo wants to merge 1 commit intovercel-labs:mainfrom
huntharo wants to merge 1 commit intovercel-labs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cloning repository...with a generic private-repo timeoutWhat Changed
This patch adds a lightweight SSH preflight in
src/git.tsbeforegit clonestarts:ssh -G <host>to resolveIdentityFileandIdentitiesOnlyssh-keygen -y -P '' -f <identity>ssh-add -T <identity>.pubGitCloneErrorimmediatelyThis branch does not implement the interactive retry yet. It only removes the dead-end where a non-interactive SSH clone sits behind the spinner until the 60s timeout.
Verification
Automated:
pnpm test src/git.test.tspnpm format:checkManual validation performed while developing this fix:
npx skills add --list git@github-passphrase-giphy:Giphy/giphy-codex-skills.gitnpx skills add --list git@github-1p-giphy:Giphy/giphy-codex-skills.gitSanitized SSH config snippets used for repro:
SSH with Passphrase - No SSH Agent
Before - Hangs for 60 Seconds
After - SSH with Passphrase - Fast Fails (< 1 second)
Notes
GIT_TERMINAL_PROMPT=0does not suppress SSH passphrase prompts; it only affects Git's own credential promptingCtrl-Cwork normally