[GrowthBook provider] Auto refresh flags with a stale-while-revalidate strategy #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jdorn is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
AAorris
approved these changes
Jul 31, 2025
AAorris
reviewed
Jul 31, 2025
Contributor
AAorris
left a comment
AAorris
left a comment
There was a problem hiding this comment.
Sorry for the delay here! It looks good to me.
Could you add a changeset pnpm changeset before merging?
dferber90
reviewed
Aug 1, 2025
dferber90
approved these changes
Nov 7, 2025
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Currently in the GrowthBook adapter, flags are fetched once at server startup, stored in-memory, and never refreshed.
This PR changes it so that every time a flag is evaluated, we refresh in the background from either Edge Config or the GrowthBook API (depending on which one the adapter is configured to use).
New adapter options / methods
There is a new adapater method
refresh()that can be called manually.Testing
I tested in a new Next.js app with and without Edge Config and verified that features refreshed without requiring an app restart. Also verified that when not using Edge Config, an in-memory cache is used to throttle network requests.
Because of the stale-while-revalidate logic for both Edge Config and GrowthBook's built-in fetching, it may take an extra refresh for changes to be picked up.